Bug 117556

Summary:

"Open Video in New Window" doesn't make sense in fullscreen

Product:

WebKit

Reporter:

Ruth Fong <ruthiecftg>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, eric.carlson, jer.noble, jonlee, ruthiecftg, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Ruth Fong 2013-06-12 11:53:14 PDT

The "Open Video in New Window" item should be removed from the contextual menu when in fullscreen because it isn't useful then.

A mediaIsInFullscreen() method needs to be exposed in order to decide when to show the "Open Video in New Window" item.

Comment 1 Ruth Fong 2013-06-12 11:54:25 PDT

<rdar://problem/14069845>

Comment 2 Ruth Fong 2013-06-12 12:03:42 PDT

Created attachment 204496 [details]
Patch

Comment 3 Beth Dakin 2013-06-12 12:33:51 PDT

Comment on attachment 204496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204496&action=review

> Source/WebKit2/ChangeLog:14
> +        Hooks into new InjectedBundleHitTestResult::mediaIsInFullscreen() method.

This is a nitpick, but in the future, you should add some newlines in this section of the ChangeLog to make it a little more readable.

Comment 4 WebKit Commit Bot 2013-06-12 12:58:38 PDT

Comment on attachment 204496 [details]
Patch

Clearing flags on attachment: 204496

Committed r151520: <http://trac.webkit.org/changeset/151520>

Comment 5 WebKit Commit Bot 2013-06-12 12:58:40 PDT

All reviewed patches have been landed.  Closing bug.