Summary: | [GTK] MiniBrowser doesn't solve the saving location when there are no XDG settings | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andres Gomez Garcia <agomez> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cgarcia, commit-queue, eocanha, gustavo, mrobinson, pnormand, rego | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Andres Gomez Garcia
2013-06-12 05:04:02 PDT
This problem can be corrected locally in MiniBrowser but it may be worth correcting actually in the default method implemented by the WebKit2Gtk library. Created attachment 204427 [details]
Patch
Added Enrique to CC. Comment on attachment 204427 [details]
Patch
This looks good to me, but I think this is actually a bug in the default implementation of decide-destination. Let's fix it in WebKitDownload and all other apps using the API will benefit from it. Note that in this case we would be updating the internal destination to NULL and emitting the notify signal.
(In reply to comment #4) > (From update of attachment 204427 [details]) > This looks good to me, but I think this is actually a bug in the default implementation of decide-destination. Let's fix it in WebKitDownload and all other apps using the API will benefit from it. Note that in this case we would be updating the internal destination to NULL and emitting the notify signal. True. Moving then to the proper component. Created attachment 205068 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 205068 [details]
Patch
Sorry for the delay reviewing it, it looks good to me, thanks!
Comment on attachment 205068 [details] Patch Clearing flags on attachment: 205068 Committed r152155: <http://trac.webkit.org/changeset/152155> All reviewed patches have been landed. Closing bug. (In reply to comment #8) > (From update of attachment 205068 [details]) > Sorry for the delay reviewing it, it looks good to me, thanks! Thanks to you for the review! |