Bug 117531

Summary: Rename [CallWith] to [ConstructorCallWith] for IDL interfaces
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, haraken, laszlo.gombos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2013-06-11 23:13:14 PDT
[CallWith] is used for methods and interfaces with slightly different meaning. When specified on an interface, [CallWith] only applies to the constructor. We should therefore rename it to [ConstructorCallWith] to increase readability.
Attachments
Patch (13.26 KB, patch)
2013-06-11 23:37 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (13.38 KB, patch)
2013-06-11 23:57 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-06-11 23:15:05 PDT
BTW, I'm happy to accept these changes to Blink to keep IDLs consistent between WebKit and Blink.
Chris Dumez
Comment 2 2013-06-11 23:37:49 PDT
Created attachment 204416 [details] Patch
Chris Dumez
Comment 3 2013-06-11 23:39:15 PDT
(In reply to comment #1) > BTW, I'm happy to accept these changes to Blink to keep IDLs consistent between WebKit and Blink. Great, consistency at IDL level would be nice indeed. Thanks.
Kentaro Hara
Comment 4 2013-06-11 23:40:47 PDT
Comment on attachment 204416 [details] Patch What constructors do not need ConstructorCallWith=ScriptExecutionContext? If almost all constructors need it, we might want to make the ScriptExecutionContext parameter by default.
Chris Dumez
Comment 5 2013-06-11 23:57:48 PDT
Created attachment 204417 [details] Patch - Removed [ConstructorCallWith] statement from interface with custom constructors as this has no effect. I looked into how many interfaces need the ScriptExecutionContext for their constructor. There are 30 interfaces with non-custom constructors. 14 of those require the ScriptExecutionContext for their constructor.
Kentaro Hara
Comment 6 2013-06-12 00:00:58 PDT
Comment on attachment 204417 [details] Patch > There are 30 interfaces with non-custom constructors. 14 of those require the ScriptExecutionContext for their constructor. Thanks, then it would make sense to have the IDL attribute.
WebKit Commit Bot
Comment 7 2013-06-12 05:25:49 PDT
Comment on attachment 204417 [details] Patch Clearing flags on attachment: 204417 Committed r151495: <http://trac.webkit.org/changeset/151495>
WebKit Commit Bot
Comment 8 2013-06-12 05:25:51 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 9 2013-06-12 05:45:44 PDT
Updated wiki accordingly in http://trac.webkit.org/wiki/WebKitIDL?action=diff&version=126&old_version=125
Note You need to log in before you can comment on or make changes to this bug.