Rename [CallWith] to [ConstructorCallWith] for IDL interfaces

• Component: Bindings
• Status: RESOLVED FIXED

[Chris Dumez]

[CallWith] is used for methods and interfaces with slightly different meaning. When specified on an interface, [CallWith] only applies to the constructor. We should therefore rename it to [ConstructorCallWith] to increase readability.

[Kentaro Hara]

BTW, I'm happy to accept these changes to Blink to keep IDLs consistent between WebKit and Blink.

[Chris Dumez]

Created attachment 204416 [details]
Patch

[Chris Dumez]

(In reply to comment #1)
> BTW, I'm happy to accept these changes to Blink to keep IDLs consistent between WebKit and Blink.

Great, consistency at IDL level would be nice indeed. Thanks.

[Kentaro Hara]

Comment on attachment 204416 [details]
Patch

What constructors do not need ConstructorCallWith=ScriptExecutionContext?

If almost all constructors need it, we might want to make the ScriptExecutionContext parameter by default.

[Chris Dumez]

Created attachment 204417 [details]
Patch

- Removed [ConstructorCallWith] statement from interface with custom constructors as this has no effect.

I looked into how many interfaces need the ScriptExecutionContext for their constructor.
There are 30 interfaces with non-custom constructors. 14 of those require the ScriptExecutionContext for their constructor.

[Kentaro Hara]

Comment on attachment 204417 [details]
Patch

> There are 30 interfaces with non-custom constructors. 14 of those require the ScriptExecutionContext for their constructor.

Thanks, then it would make sense to have the IDL attribute.

[WebKit Commit Bot]

Comment on attachment 204417 [details]
Patch

Clearing flags on attachment: 204417

Committed r151495: <http://trac.webkit.org/changeset/151495>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

Updated wiki accordingly in http://trac.webkit.org/wiki/WebKitIDL?action=diff&version=126&old_version=125