Bug 11752

Summary: [CSS 3] missing support for cursor selector 'copy'
Product: WebKit Reporter: Lars Næsbye Christensen <lars>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ddkilzer
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch to support CSS 3 cursor selector 'copy' ap: review+

Description Lars Næsbye Christensen 2006-12-04 23:08:03 PST
The CSS cursor selector is not supported by WebKit.
Comment 1 Lars Næsbye Christensen 2006-12-04 23:09:57 PST
Created attachment 11734 [details]
patch to support CSS 3 cursor selector 'copy'

The next-to-last we need for full cursor selector support....'none' is a bit trickier.....
Comment 2 Alexey Proskuryakov 2006-12-05 00:28:22 PST
Comment on attachment 11734 [details]
patch to support CSS 3 cursor selector 'copy'

r=me
Comment 3 Alexey Proskuryakov 2006-12-05 00:38:45 PST
Committed revision 18017.
Comment 4 David Kilzer (:ddkilzer) 2006-12-05 09:54:36 PST
Comment on attachment 11734 [details]
patch to support CSS 3 cursor selector 'copy'

>Index: WebCore/css/CSSValueKeywords.in
>===================================================================
>--- WebCore/css/CSSValueKeywords.in	(revision 18014)
>+++ WebCore/css/CSSValueKeywords.in	(working copy)
>@@ -170,7 +170,7 @@ no-repeat
> # CSS_PROP__WEBKIT_BACKGROUND_COMPOSITE:
> #
> clear
>-copy
>+# copy
> source-over
> source-in
> source-out

Did we really want to check that in?  Shouldn't that line just be deleted?
Comment 5 David Kilzer (:ddkilzer) 2006-12-05 09:56:58 PST
(In reply to comment #4)
> (From update of attachment 11734 [details] [edit])
> >Index: WebCore/css/CSSValueKeywords.in
> >===================================================================
> >--- WebCore/css/CSSValueKeywords.in	(revision 18014)
> >+++ WebCore/css/CSSValueKeywords.in	(working copy)
> >@@ -170,7 +170,7 @@ no-repeat
> > # CSS_PROP__WEBKIT_BACKGROUND_COMPOSITE:
> > #
> > clear
> >-copy
> >+# copy
> > source-over
> > source-in
> > source-out
> 
> Did we really want to check that in?  Shouldn't that line just be deleted?

Actually, I'm not sure that commenting that out is even correct?!
Comment 6 Alexey Proskuryakov 2006-12-05 10:16:10 PST
Yes - that's how duplicate names are treated elsewhere in this file.