Bug 117476
| Summary: | Styles in nested shadows are not recalculated correctly on insertion | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, hyatt, koivisto, simon.fraser |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/dc5fc6795eacef884fe9910cbe2aa961d1809ca1
Moved StyleElement::insertedIntoDocument into didNotifySubtreeInsertions.
We should avoid style-recalc during subtree insertions.
If invoke style-recalc, we might invoke createRenderer for elements that have not been inserted into document yet.
(i.e. the elements' inDocument flags are false).
The recalc also clears needsStyleRecalc flag. This blocks correct style-recalc.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
Link - https://jsfiddle.net/zsbu7ctg/
I took the latest code of this test from source.chromium.org and Safari 16 is passing the test:
PASS backgroundColor is "rgb(0, 128, 0)"
PASS successfullyParsed is true
So as Chrome Canary 107 and Firefox Nightly 106. Anything else required? Thanks!
Ryosuke Niwa
This code has been refactored enough that this patch is no longer meaningful.