Bug 117462
| Summary: | Fix RenderLayer::collectLayers logic bug | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | dino, hyatt, mattwoodrow, simon.fraser, thorton |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/3dfbb71ed8eefeca1618b85c72b912c051314836
In collectLayers, if a layer is normal flow only, we will not add it
to the z-order lists. The trouble is that
RenderLayer::shouldBeNormalFlowOnly depends on
RenderLayer::needsCompositedScrolling. This means that the result of
collectLayers depends on the opt-in decision of other layers,
something which must not happen: when we are determining opt-in, we
must never depend on the opt-in decision for another layer. This CL
makes this function opt-in agnostic when it needs to be.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Matt Woodrow
Our version of `RenderLayer::shouldBeNormalFlowOnly` does not check `RenderLayer::needsCompositedScrolling` (or an equivalent) as far as I can tell.