Bug 117461

Summary:

editing/undo/undo-after-event-edited.html can be flaky

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, darin, enrica, kling, koivisto

Priority:

Keywords:

BlinkMergeCandidate

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the test	none

Ryosuke Niwa

Reported 2013-06-10 18:33:17 PDT

Merge https://chromium.googlesource.com/chromium/blink/+/515de860730b34289df5805b40adb2535a9a8ba1. This patch changes a test script, undo-after-event-edited.html, stable, by executing JavaScript after document finished loading. When calling Range.extractContents() for selection selected whole document w/o body, SimplifiedBackwardsTextIterator creates Range object with DocumentType which is illegal argument for Range construction.

Attachments
Fixes the test (1.35 KB, patch) 2013-06-10 20:56 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2013-06-10 20:56:01 PDT

Created attachment 204281 [details] Fixes the test

WebKit Commit Bot

Comment 2 2013-06-11 08:09:29 PDT

Comment on attachment 204281 [details] Fixes the test Clearing flags on attachment: 204281 Committed r151438: <http://trac.webkit.org/changeset/151438>

WebKit Commit Bot

Comment 3 2013-06-11 08:09:31 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.