Bug 117457
| Summary: | Remove the inline Vector capacity in SVGGlyphMap | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, barraclough, bfulgham, pdr, thorton, zimmermann |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/f77a5392726f68494fc2bff8024b181549edca66
Don't pre-reserve massive amounts of memory in SVGGlyphMap.
This reduces the size of SVGFontElement from 20KB_ to ~200 bytes.
diff --git a/Source/core/svg/SVGGlyphMap.h b/Source/core/svg/SVGGlyphMap.h
index 1db5048..1e4153b 100644
--- a/Source/core/svg/SVGGlyphMap.h
+++ b/Source/core/svg/SVGGlyphMap.h
@@ -155,7 +155,7 @@
private:
GlyphMapLayer m_rootLayer;
- Vector<SVGGlyph, 256> m_glyphTable;
+ Vector<SVGGlyph> m_glyphTable;
HashMap<String, Glyph> m_namedGlyphs;
int m_currentPriority;
};
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
This commit removed "SVGGlyphMap.h":
https://github.com/WebKit/WebKit/commit/4738cfa45c28bf60411bd29119e154f4bae7d963
I am also not able to find anything with "GlyphMapLayer", is this needed anymore? Thanks!
Ryosuke Niwa
We got rid of this code.