Summary: | [BlackBerry] Smarter algorithm to determine the backingstore rect | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jakob Petsovits <jpetsovits> | ||||
Component: | WebKit BlackBerry | Assignee: | Jakob Petsovits <jpetsovits> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | anilsson, cgarcia, commit-queue, manyoso, rwlbuis | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Jakob Petsovits
2013-06-10 17:18:51 PDT
Created attachment 204231 [details]
Patch
The style checker is complaining about a variable named 'l'. I believe that in the context (l/r/u/d for left/right/up/down), that's clear and optimal. Hopefully it'll still go through the bots (and review), or something.
Attachment 204231 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/BackingStore.cpp', u'Source/WebKit/blackberry/Api/BackingStore_p.h', u'Source/WebKit/blackberry/ChangeLog']" exit_code: 1
Source/WebKit/blackberry/Api/BackingStore.cpp:855: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 204231 [details]
Patch
This looks great! Like you said, this algorithm would apply to AC layer scrolling too, once the visibility patch lands, and visibility is represented as a simple rect. Perhaps we can extract this algorithm into a reusable class in the future and use it in the AC code too.
Comment on attachment 204231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204231&action=review Looks good, please think about the more verbose naming before landing. >> Source/WebKit/blackberry/Api/BackingStore.cpp:855 >> + const float l = expandLeft; > > l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] More verbose would be better but up to you. Comment on attachment 204231 [details] Patch Clearing flags on attachment: 204231 Committed r151503: <http://trac.webkit.org/changeset/151503> All reviewed patches have been landed. Closing bug. |