Bug 117448

Summary: Clean up the initializer mess in Document
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, dcheng, esprehn+autocc, kling, koivisto
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+

Ryosuke Niwa
Reported 2013-06-10 16:49:16 PDT
https://chromium.googlesource.com/chromium/blink/+/e54ba8d3b62b0245ecdf2f3ec11cd33b4035a4d7 Before this, some members were initialized in the initializer list and others were initialized in the body of the constructor. As far as I can tell, it's OK for everything to just be in the initializer list. As a bonus, I found two completely unused members in Document (and a local static) and removed them as well.
Attachments
Patch (5.91 KB, patch)
2013-06-10 18:01 PDT, Benjamin Poulain 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-06-10 18:01:56 PDT
Created attachment 204268 [details] Patch
Ryosuke Niwa
Comment 2 2013-06-10 18:04:03 PDT
Comment on attachment 204268 [details] Patch Let's wait for EWS though.
Ryosuke Niwa
Comment 3 2013-06-10 18:25:59 PDT
Apparently it got reverted in https://chromium.googlesource.com/chromium/blink/+/c3ff928bbdc8eef2bb274516949f31345ca24569.
Benjamin Poulain
Comment 4 2013-06-11 13:40:48 PDT
Committed r151466: <http://trac.webkit.org/changeset/151466>
Benjamin Poulain
Comment 5 2013-06-11 13:41:40 PDT
(In reply to comment #3) > Apparently it got reverted in https://chromium.googlesource.com/chromium/blink/+/c3ff928bbdc8eef2bb274516949f31345ca24569. Should be good, I did not copy the bad parts of the original patch.
Note You need to log in before you can comment on or make changes to this bug.