Bug 117447
| Summary: | Allow removing empty childs even if !canCollapseAnonymousBlockChild() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | cbiesinger, dino, hyatt, simon.fraser |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/8f76a1a2fefcfdc62e7ca95cc7cd0dc4f4ad346b
The purpose of canCollapseAnonymousBlockChild is to prevent moving
non-block children to the parent of the anonymous block. However,
when there are no children, we still want to remove the empty block.
See http://trac.webkit.org/changeset/126071 for where the code got added
and the new test case for why this matters.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Christian Biesinger
You should hold off on merging that diff; there were issues with it and I reverted it. Working on a better version now.
Christian Biesinger
Final version of that patch was http://src.chromium.org/viewvc/blink?view=revision&revision=152454, feel free to merge that.