Bug 117444
| Summary: | Correctly handle auto margins for flipped writing modes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, dino, hyatt |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/882b259b17c19f10e9a7b36bf9ca54a399b5f416
Correctly handle auto margins for flipped writing modes
Handling of auto margins for flipped writing modes (vertical-rl and
horizontal-bt) was broken. We need to adjust the position if
margin-before is auto, and for them, that's bottom/right, not top/left.
This was found by noticing unexpected alignment in
flex-flow-auto-margins.html. I am not sure why
flex-align-vertical-writing-mode.html had the expectations it had, as
far as I can tell, they were just wrong.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
https://github.com/WebKit/WebKit/blob/61a1009d68c4718583337288956333b630f6e904/Source/WebCore/rendering/RenderFlexibleBox.cpp#L1299
It is already done and I don't think this is required anymore.
Changing status to "RESOLVED CONFIGURATION CHANGED". Thanks!