Bug 11744

Summary: Setting the 'content' property dynamically has no effect
Product: WebKit Reporter: mitz
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Test case
none
Compare content data when computing style diff
none
Now with extra parentheses for better readability! hyatt: review+

mitz
Reported 2006-12-03 08:00:19 PST
The attached test case demonstrates that changing the 'content' CSS property of an element does not replace its content with the specified content. Toggling the 'display' property to 'none' and back causes the new content to show. RenderStyle already has a contentDataEquivalent() method (used for pseudo elements), but RenderStyle::diff doesn't check it.
Attachments
Test case (650 bytes, text/html)
2006-12-03 08:03 PST, mitz 		no flags
Details
Compare content data when computing style diff (8.60 KB, patch)
2007-01-02 23:50 PST, mitz 		no flags
DetailsFormatted DiffDiff
Now with extra parentheses for better readability! (8.60 KB, patch)
2007-01-03 01:03 PST, mitz 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2006-12-03 08:03:11 PST
Created attachment 11720 [details] Test case
mitz
Comment 2 2006-12-03 08:53:39 PST
(In reply to comment #0) > RenderStyle::diff doesn't check it. Oops, make that Node::diff :-)
mitz
Comment 3 2007-01-02 23:50:18 PST
Created attachment 12180 [details] Compare content data when computing style diff
mitz
Comment 4 2007-01-03 01:03:31 PST
Created attachment 12182 [details] Now with extra parentheses for better readability!
Dave Hyatt
Comment 5 2007-01-03 01:04:13 PST
Comment on attachment 12182 [details] Now with extra parentheses for better readability! r=me
David Kilzer (:ddkilzer)
Comment 6 2007-01-03 21:39:31 PST
Committed revision 18572.
Note You need to log in before you can comment on or make changes to this bug.