Bug 117428
| Summary: | applyAuthorStyles and resetStyleInheritance should use shadow root's setNeedsStyleRecalc, not shadow host's | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | kling, koivisto |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/6631b7cdff92c6c3261e037936ae5213f0eebdf7
- ShadowRoot::recalcStyle should see its styleChangeType. If FullStyleChange, use Force for its children's style recalc.
- Changed applyAuthorStyles and resetStyleInheritance to check whether the modified shadow root is inert or not. If inert, we don't need style recalc.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Or rather https://chromium.googlesource.com/chromium/blink/+/d9ea052fa74897d53f1f7fdfbcd6ba9cf7f7e113
Ryosuke Niwa
We've since implemented shadow DOM v1 API.