Bug 117424
| Summary: | Don't stretch margin: auto items in a vertical flexbox | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, dino, hyatt, simon.fraser, yuki.sekiguchi, zalan |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/d4de57852c154677cdb4613cbd3e5a0c9cc72307
Even with align-self: stretch (the default), we shouldn't stretch items
that have margin: auto;
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Yuki Sekiguchi
Is Bug 116944 same bug?
Ahmad Saleem
Test Case from the patch - https://jsfiddle.net/h4cfoum7/show
It works same across all browsers (Chrome Canary 108, Firefox Nightly 106 and Safari Technology Preview 153).
Is something need from here?
Ahmad Saleem
Marking this as "RESOLVED CONFIGURATION CHANGED" since below commit added bits from Blink including these bits in 2017:
https://github.com/WebKit/WebKit/commit/1c4cbfe7755eb1dffdb76c77dc682b3c1f077576
and as mentioned in Comment 02, the test works fine in Safari.