| Summary: | [CSS Regions] Rename region-overflow to region-fragment | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Radu Stavila <stavila> | ||||||||||
| Component: | CSS | Assignee: | Radu Stavila <stavila> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | allan.jensen, commit-queue, esprehn+autocc, glenn, macpherson, menard, rhauck, rniwa, stavila, WebkitBugTracker | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Radu Stavila
2013-06-10 01:38:11 PDT
Created attachment 204154 [details]
Patch
Comment on attachment 204154 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204154&action=review > LayoutTests/ChangeLog:8 > + at http://www.w3.org/TR/css3-regions/#the-region-fragment-property Should we put this link: http://www.w3.org/TR/2013/WD-css3-regions-20130528 instead of the latest WD link? > LayoutTests/ChangeLog:27 > + (testComputedStyleWebKitRegionFragment): I would remove these lines from the changelog, i don't think changes to these functions should be mentioned in the changelog. > LayoutTests/ChangeLog:30 > + (testComputedStyle): Same here. > PerformanceTests/ChangeLog:12 > + (.region): I would remove this line too. Created attachment 204158 [details]
Patch
Comment on attachment 204158 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204158&action=review > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:372 > + CSSPropertyWebkitRegionFragment, Not sure if this is intended to be alpha-sorted; just a note. Comment on attachment 204158 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204158&action=review >> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:372 >> + CSSPropertyWebkitRegionFragment, > > Not sure if this is intended to be alpha-sorted; just a note. Since RegionOverflow was already before RegionBreakAfter, I don't believe it was alpha sorted. Created attachment 204159 [details]
Patch
Created attachment 204160 [details]
Patch
Comment on attachment 204160 [details] Patch Clearing flags on attachment: 204160 Committed r151394: <http://trac.webkit.org/changeset/151394> All reviewed patches have been landed. Closing bug. *** Bug 103686 has been marked as a duplicate of this bug. *** |