| Summary: | Scrolling with platformWidget and delegateScrolling is incorrectly clamped | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | buildbot, rniwa, simon.fraser, thorton | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Benjamin Poulain
2013-06-07 22:09:16 PDT
Created attachment 204085 [details]
Patch
Comment on attachment 204085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204085&action=review > Source/WebCore/ChangeLog:14 > + we do not let those external scrolling handle the out of bound scrolling. external scrolling… what? Check this up ^^, that will explain a bit :) Comment on attachment 204085 [details] Patch Attachment 204085 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/725418 New failing tests: fast/dom/rtl-scroll-to-leftmost-and-resize.html fast/block/positioning/vertical-rl/fixed-positioning.html fast/dom/horizontal-scrollbar-when-dir-change.html fast/dom/vertical-scrollbar-when-dir-change.html fast/dom/scroll-reveal-top-overflow.html fast/dom/scroll-reveal-left-overflow.html Created attachment 204086 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3
Created attachment 204103 [details]
Patch
requestScrollPositionUpdate() is virtual. This makes more sense. Comment on attachment 204103 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204103&action=review > Source/WebCore/platform/ScrollView.cpp:429 > + if (requestScrollPositionUpdate(newScrollPosition)) > + return; Any downside to calling this for non-frame views? (In reply to comment #9) > (From update of attachment 204103 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204103&action=review > > > Source/WebCore/platform/ScrollView.cpp:429 > > + if (requestScrollPositionUpdate(newScrollPosition)) > > + return; > > Any downside to calling this for non-frame views? 3 jumps. The base implementation of requestScrollPositionUpdate() just return false. Thanks for the review. Committed r151356: <http://trac.webkit.org/changeset/151356> |