| Summary: | Compile WebCoreTestShimLibrary.cpp on iOS, but exclude the Carbon bits | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||
| Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ddkilzer | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Andy Estes
2013-06-07 13:14:38 PDT
Created attachment 204063 [details]
Patch
Comment on attachment 204063 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204063&action=review r=me > Source/WebCore/testing/WebCoreTestShimLibrary.cpp:28 > +#if !defined(TARGET_OS_IPHONE) || !TARGET_OS_IPHONE We can't use #include <wtf/Platform.h> and #if !PLATFORM(IOS) here? (In reply to comment #2) > (From update of attachment 204063 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204063&action=review > > r=me > > > Source/WebCore/testing/WebCoreTestShimLibrary.cpp:28 > > +#if !defined(TARGET_OS_IPHONE) || !TARGET_OS_IPHONE > > We can't use #include <wtf/Platform.h> and #if !PLATFORM(IOS) here? We could, but we'd have to add WTF/JavaScriptCore to the target's header search path. It seemed easier to just use TargetConditionals.h. Committed r151334: <http://trac.webkit.org/changeset/151334> |