Bug 117360

Summary: Compile WebCoreTestShimLibrary.cpp on iOS, but exclude the Carbon bits
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mrowe: review+

Andy Estes
Reported 2013-06-07 13:14:38 PDT
Compile WebCoreTestShimLibrary.cpp on iOS, but exclude the Carbon bits
Attachments
Patch (2.74 KB, patch)
2013-06-07 13:24 PDT, Andy Estes 		mrowe: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2013-06-07 13:24:04 PDT
Created attachment 204063 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2013-06-07 13:29:16 PDT
Comment on attachment 204063 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204063&action=review r=me > Source/WebCore/testing/WebCoreTestShimLibrary.cpp:28 > +#if !defined(TARGET_OS_IPHONE) || !TARGET_OS_IPHONE We can't use #include <wtf/Platform.h> and #if !PLATFORM(IOS) here?
Andy Estes
Comment 3 2013-06-07 13:31:42 PDT
(In reply to comment #2) > (From update of attachment 204063 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204063&action=review > > r=me > > > Source/WebCore/testing/WebCoreTestShimLibrary.cpp:28 > > +#if !defined(TARGET_OS_IPHONE) || !TARGET_OS_IPHONE > > We can't use #include <wtf/Platform.h> and #if !PLATFORM(IOS) here? We could, but we'd have to add WTF/JavaScriptCore to the target's header search path. It seemed easier to just use TargetConditionals.h.
Andy Estes
Comment 4 2013-06-07 13:33:32 PDT
Committed r151334: <http://trac.webkit.org/changeset/151334>
Note You need to log in before you can comment on or make changes to this bug.