Bug 117350

Summary: Get rid of outdated raises() from Web IDL
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, eflews.bot, gtk-ews, gyuyoung.kim, haraken, igor.oliveira, laszlo.gombos, rego+ews, rniwa, tonikitoo, webkit-ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117400    
Attachments:
Description Flags
Patch
webkit-ews: commit-queue-
Patch none

Description Chris Dumez 2013-06-07 08:37:18 PDT
Web IDL no longer specifies exceptions for operations / methods and this is now only explained in prose. WebKit still needs to know that an exception can be raised though (to pass ExceptionCode argument) so we should add a WebKit-specific IDL extended attribute:
RaisesException (naming is consistent with Blink).
Comment 1 Chris Dumez 2013-06-07 10:07:11 PDT
Created attachment 204050 [details]
Patch
Comment 2 Early Warning System Bot 2013-06-07 10:14:11 PDT
Comment on attachment 204050 [details]
Patch

Attachment 204050 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/743518
Comment 3 kov's GTK+ EWS bot 2013-06-07 10:17:11 PDT
Comment on attachment 204050 [details]
Patch

Attachment 204050 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/661574
Comment 4 EFL EWS Bot 2013-06-07 10:19:32 PDT
Comment on attachment 204050 [details]
Patch

Attachment 204050 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/755259
Comment 5 Chris Dumez 2013-06-07 10:19:51 PDT
Created attachment 204052 [details]
Patch
Comment 6 WebKit Commit Bot 2013-06-07 14:27:19 PDT
Comment on attachment 204052 [details]
Patch

Clearing flags on attachment: 204052

Committed r151336: <http://trac.webkit.org/changeset/151336>
Comment 7 WebKit Commit Bot 2013-06-07 14:27:23 PDT
All reviewed patches have been landed.  Closing bug.