Bug 117348 – [Qt][WK2] Implement session restore/save in WebKit2

• Component: WebKit2
• Status: RESOLVED INVALID

[Hyungchan Kim]

I filled the empty bodies of 2 functions in WebPageProxy.cpp to enable session restore/save in WebKit2 Qt.

WKPage.h
WK_EXPORT WKDataRef WKPageCopySessionState(WKPageRef page, void* context, WKPageSessionStateFilterCallback urlAllowedCallback);
WK_EXPORT void WKPageRestoreFromSessionState(WKPageRef page, WKDataRef sessionStateData);

WebPageProxy.h
void WebPageProxy::restoreFromSessionStateData(WebData*)
PassRefPtr<WebData> WebPageProxy::sessionStateData(WebPageProxySessionStateFilterCallback, void*) const

Most of the source were come from WebPageProxyCF.cpp, WebBackForwardListCF.cpp.

[Hyungchan Kim]

Created attachment 204044 [details]
Patch

[WebKit Commit Bot]

Attachment 204044 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp', u'Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h', u'Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h', u'Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_sessionSaveRestore.qml', u'Source/WebKit2/UIProcess/WebBackForwardList.cpp', u'Source/WebKit2/UIProcess/WebBackForwardList.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp']" exit_code: 1
Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1603:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 204044 [details]
Patch

Attachment 204044 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/792213

[EFL EWS Bot]

Comment on attachment 204044 [details]
Patch

Attachment 204044 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/792215

[Hyungchan Kim]

Created attachment 204046 [details]
Patch

[Anders Carlsson]

Comment on attachment 204046 [details]
Patch

Using the IPC encoding mechanism for encoding back/forward lists was a great mistake and I'd hate for other ports to repeat it.

[Hyungchan Kim]

(In reply to comment #6)
> (From update of attachment 204046 [details])
> Using the IPC encoding mechanism for encoding back/forward lists was a great mistake and I'd hate for other ports to repeat it.

Do you hate using IPC encoding mechanism in here because is ArgumentEncoder/Decoder only for IPC?
If so, how about implementing derived class from Encoder.h? But, it's body will almost be the same with impl of ArgumentDecoder/Encoder.

Or, I can give up general IPC and then implement Qt specific code like HistoryItemQt.cpp

[Hyungchan Kim]

Created attachment 204379 [details]
Patch

[EFL EWS Bot]

Comment on attachment 204379 [details]
Patch

Attachment 204379 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/780354

[Build Bot]

Comment on attachment 204379 [details]
Patch

Attachment 204379 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/791425

[Hyungchan Kim]

Created attachment 204384 [details]
Patch

[EFL EWS Bot]

Comment on attachment 204384 [details]
Patch

Attachment 204384 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/822157

[Hyungchan Kim]

Created attachment 204418 [details]
Patch

[Anders Carlsson]

Comment on attachment 204418 [details]
Patch

Qt has been removed, clearing review flags.

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.