Summary: | SVGPoint, SVGRect, etc are implemented as PODs | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||||||||||
Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | eric, sam | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 416.x | ||||||||||||||
Hardware: | Mac | ||||||||||||||
OS: | OS X 10.4 | ||||||||||||||
Attachments: |
|
Description
Oliver Hunt
2006-12-01 13:51:40 PST
Created attachment 11705 [details]
Testcase
Testcase demonstrates using SVGPoint as a reference. Behaviour is borked in Opera, correct in FFX
Created attachment 11712 [details]
Initial patch adressing problems.
This patch doesn't contain any ChangeLogs, Rob wants to finish
it and implement matrixTransform() - as I don't have any time
anymore tonight.
Created attachment 11713 [details]
Initial set of LayoutTests.
Created attachment 11715 [details]
Improved patch
This patch adds matrixTransform handling and a test for it. Sam Weinig added the objC part as well as the FloatPoint additions. I think we may need more testing seeing olliej's test, OTOH it is a big improvement IMHO.
Cheers,
Rob.
Comment on attachment 11715 [details]
Improved patch
FloatPoint::matrixTransform should be in FloatPointCG.cpp
(In reply to comment #5) > (From update of attachment 11715 [details] [edit]) > FloatPoint::matrixTransform should be in FloatPointCG.cpp > I disagree, I think FloatPoint::matrixTransform should be in FloatPoint.cpp as it is entirely platform independant. I also think static_casts should be used instead of the c-style casts. True, i'd completely forgotten that AffineTransform isn't a CG specific type, in either case it still needs to be pulled from FloatPointMac.cpp *** Bug 11685 has been marked as a duplicate of this bug. *** Created attachment 11718 [details]
Updated patch
Incorporated comments
.
Comment on attachment 11718 [details]
Updated patch
looks fine to me
I'd normally expect layout tests to produce green/red rects -- but "passed" failed" is good too :D
Landed in r17993. |