Bug 117334

Summary: [GTK] autoreconf fails to find some macros without -I Source/autotools
Product: WebKit Reporter: Emilio Pozuelo Monfort <pochu27>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: berto, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   

Description Emilio Pozuelo Monfort 2013-06-07 02:05:55 PDT 
If I run `autoreconf -fiv' on a webkitgtk tarball I get:

libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, `Source/autotools'.
libtoolize: copying file `Source/autotools/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `Source/autotools'.
libtoolize: copying file `Source/autotools/libtool.m4'
libtoolize: copying file `Source/autotools/ltoptions.m4'
libtoolize: copying file `Source/autotools/ltsugar.m4'
libtoolize: copying file `Source/autotools/ltversion.m4'
libtoolize: copying file `Source/autotools/lt~obsolete.m4'
libtoolize: Remember to add `LT_INIT' to configure.ac.
libtoolize: Consider adding `-I Source/autotools' to ACLOCAL_AMFLAGS in Makefile.am.

This is a problem with some versions of aclocal such as 1.11. 1.13 seems to work even though it still throws that message. We should probably add ACLOCAL_AMFLAGS+="-I Source/autotools" to be on the safe side.
Comment 1 Alberto Garcia 2013-09-09 05:40:16 PDT 
(In reply to comment #0)
> This is a problem with some versions of aclocal such as 1.11. 1.13 seems to work even though it still throws that message. We should probably add ACLOCAL_AMFLAGS+="-I Source/autotools" to be on the safe side.

Isn't that already defined?
Comment 2 Emilio Pozuelo Monfort 2013-09-09 06:20:57 PDT 
(In reply to comment #1)
> (In reply to comment #0)
> > This is a problem with some versions of aclocal such as 1.11. 1.13 seems to work even though it still throws that message. We should probably add ACLOCAL_AMFLAGS+="-I Source/autotools" to be on the safe side.
> 
> Isn't that already defined?

Not in GNUmakefile.am. We have it in configure.ac, not sure why. Both the autoreconf output and the autoconf manual say it needs to be set in Makefile.am.
Comment 3 Alberto Garcia 2013-09-09 09:04:42 PDT 
(In reply to comment #2)
> Both the autoreconf output and the autoconf manual say it needs to be set in Makefile.am.

Looks like libtoolize doesn't even use GNUmakefile.am ...

   if test -f Makefile.am; then
     my_macrodir_is_next=false
     for arg in `$SED "$my_sed_aclocal_flags" Makefile.am`; do
        [...]
Comment 4 Martin Robinson 2014-03-25 15:20:10 PDT 
Autotools is gone now.