Bug 117328

Summary: Completely initialise ChildProcess state on launch
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch sam: review+

Oliver Hunt
Reported 2013-06-06 17:53:04 PDT
Completely initialise ChildProcess state on launch
Attachments
Patch (1.30 KB, patch)
2013-06-06 17:53 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (1.50 KB, patch)
2013-06-06 18:03 PDT, Oliver Hunt 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2013-06-06 17:53:41 PDT
Created attachment 203984 [details] Patch
Sam Weinig
Comment 2 2013-06-06 17:59:59 PDT
Comment on attachment 203984 [details] Patch Process initialization should happen in ChildProcess::initialize() or one of its subclasses. It seems like setProcessSuppressionEnabled(false); is already called from ChildProcess::platformInitialize(), why is that not enough?
Oliver Hunt
Comment 3 2013-06-06 18:03:07 PDT
Created attachment 203986 [details] Patch
Sam Weinig
Comment 4 2013-06-06 18:07:36 PDT
Comment on attachment 203986 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203986&action=review > Source/WebKit2/ChangeLog:8 > + Don't rely on receiving a message from the UI process as part of our initialisation I don't think this make sense. > Source/WebKit2/Shared/mac/ChildProcessMac.mm:151 > - setProcessSuppressionEnabled(false); > + setProcessSuppressionEnabledInternal(false); You should note why you are using the weird internal variant here.
Oliver Hunt
Comment 5 2013-06-06 18:12:26 PDT
Committed r151305: <http://trac.webkit.org/changeset/151305>
Note You need to log in before you can comment on or make changes to this bug.