Bug 117288

Summary: ResourceLoader::resourceData() should not return a PassRefPtr
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, darin, esprehn+autocc, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117289    
Attachments:
Description Flags
Patch darin: review+

Carlos Garcia Campos
Reported 2013-06-06 04:58:28 PDT
ResourceLoader is the owner of the resource data and we don't really want to transfer the ownership in resourceData().
Attachments
Patch (17.16 KB, patch)
2013-06-06 05:04 PDT, Carlos Garcia Campos 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-06-06 05:04:08 PDT
Created attachment 203924 [details] Patch
Darin Adler
Comment 2 2013-06-06 09:22:20 PDT
Comment on attachment 203924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203924&action=review > Source/WebCore/ChangeLog:10 > + Change ResourceLoader::resourceData() to return a raw pointer > + instead of a PassRefPtr since we don't want to transfer the > + ownership of the resource data. Also pass a raw pointer to Definitely a good change. > Source/WebCore/ChangeLog:14 > + CachedResource::data() so that the cached resource can decide > + whether to take a reference of the data or not, for example, > + CachedRawResource only takes a reference when buffering policy is > + BufferData. Not sure this change is as good, but it’s OK.
Carlos Garcia Campos
Comment 3 2013-06-06 09:37:16 PDT
Committed r151277: <http://trac.webkit.org/changeset/151277>
Note You need to log in before you can comment on or make changes to this bug.