Bug 117273

Summary:

Don't throttle timers if a page is doing something that might be interesting

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	barraclough: review+

Description Oliver Hunt 2013-06-05 13:26:08 PDT

Don't throttle timers if a page is doing something that might be interesting

Comment 1 Oliver Hunt 2013-06-05 13:27:31 PDT

Created attachment 203877 [details]
Patch

Comment 2 Gavin Barraclough 2013-06-05 15:19:06 PDT

Comment on attachment 203877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203877&action=review

r+

> Source/WebCore/page/Page.cpp:1285
> +            throttleTimers();

I think this is redundant to the action taken by the PageThrottler, it should already be doing the right thing.

> Source/WebCore/page/Page.cpp:1289
> +        unthrottleTimers();

ditto.

Comment 3 Oliver Hunt 2013-06-05 15:24:23 PDT

Committed r151244: <http://trac.webkit.org/changeset/151244>