| Summary: | [CSS Regions] When changing flow-from/flow-into on :hover, elements overflowing the region are not correctly repainted | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Radu Stavila <stavila> | ||||||||||||
| Component: | CSS | Assignee: | Radu Stavila <stavila> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, mibalan, mvujovic, rniwa, stavila, WebkitBugTracker | ||||||||||||
| Priority: | P2 | Keywords: | AdobeTracked | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 7555, 111585 | ||||||||||||||
| Bug Blocks: | 116295 | ||||||||||||||
| Attachments: |
|
||||||||||||||
Changing this bug to block the CSS Regions master bug, not the other way around. Created attachment 219639 [details]
Patch
Comment on attachment 219639 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219639&action=review > Source/WebCore/rendering/RenderRegion.cpp:746 > + rect.moveBy(baseRect.location()); > + rect.unite(baseRect); This pair doesn't look correct. How are rect and baseRect in the same coordinate system in unite()? baseRect is obtained with RenderBlockFlow::clippedOverflowRectForRepaint which at least in theory can have a location that differs from the box location. Created attachment 219643 [details]
Simpler approach
Comment on attachment 219643 [details] Simpler approach Attachment 219643 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/48758024 New failing tests: fast/multicol/newmulticol/column-rules-fixed-height.html Created attachment 219654 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 219744 [details]
Patch fixing failing newmulticol test
Comment on attachment 219744 [details] Patch fixing failing newmulticol test Clearing flags on attachment: 219744 Committed r160905: <http://trac.webkit.org/changeset/160905> All reviewed patches have been landed. Closing bug. |
Created attachment 203862 [details] HTML showing the problem If an element is flowed into a region and it overflows the region, upon changing the region's flow-from to "none" in the :hover style would fail to repaint the portion of the element that was outside of the region. See attached test case.