Bug 117255

Summary: [WinCairo] Fix build-webkit to build WinCairo under VS2010.
Product: WebKit Reporter: peavo
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dbates
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

peavo
Reported 2013-06-05 07:42:39 PDT
The WinCairo build fails because the configuration names has changed in the VS2010 project, and needs to be updated in the scripts.
Attachments
Patch (2.16 KB, patch)
2013-06-05 07:51 PDT, peavo 		no flags
DetailsFormatted DiffDiff
Patch (2.19 KB, patch)
2013-06-06 00:18 PDT, peavo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2013-06-05 07:51:29 PDT
Created attachment 203851 [details] Patch
Daniel Bates
Comment 2 2013-06-05 09:16:11 PDT
Comment on attachment 203851 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203851&action=review This patch looks straightforward to me. r=me > Tools/ChangeLog:3 > + [WinCairo] Build failure. Do we know when the build began failing? From briefly looking through SVN history it looks like the WinCairo broken during the transition from VS2005 to VS2010. Maybe a more appropriate bug title would be "Fix build-webkit to build WinCairo under VS2010"?
Daniel Bates
Comment 3 2013-06-05 09:17:36 PDT
(In reply to comment #2) > > Tools/ChangeLog:3 > > + [WinCairo] Build failure. > > Do we know when the build began failing? From briefly looking through SVN history it looks like the WinCairo broken during the transition from VS2005 to VS2010. Maybe a more appropriate bug title would be "Fix build-webkit to build WinCairo under VS2010"? "WinCairo broken during" => "WinCairo build has been broken since"
peavo
Comment 4 2013-06-05 11:44:01 PDT
(In reply to comment #2) > (From update of attachment 203851 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203851&action=review > > This patch looks straightforward to me. > > r=me > > > Tools/ChangeLog:3 > > + [WinCairo] Build failure. > > Do we know when the build began failing? From briefly looking through SVN history it looks like the WinCairo broken during the transition from VS2005 to VS2010. Maybe a more appropriate bug title would be "Fix build-webkit to build WinCairo under VS2010"? I'm not sure exactly when the WinCairo build started to fail.
Daniel Bates
Comment 5 2013-06-05 12:29:41 PDT
Comment on attachment 203851 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203851&action=review >>> Tools/ChangeLog:3 >>> + [WinCairo] Build failure. >> >> Do we know when the build began failing? From briefly looking through SVN history it looks like the WinCairo broken during the transition from VS2005 to VS2010. Maybe a more appropriate bug title would be "Fix build-webkit to build WinCairo under VS2010"? > > I'm not sure exactly when the WinCairo build started to fail. OK. Please update the bug title in the ChangeLog entry before landing this patch.
peavo
Comment 6 2013-06-06 00:18:10 PDT
Created attachment 203910 [details] Patch
peavo
Comment 7 2013-06-06 00:20:11 PDT
(In reply to comment #5) > > OK. Please update the bug title in the ChangeLog entry before landing this patch. Updated the title in the ChangeLog.
Daniel Bates
Comment 8 2013-06-06 07:20:20 PDT
Comment on attachment 203910 [details] Patch Thanks peavo for updating the patch. r=me
peavo
Comment 9 2013-06-06 07:27:05 PDT
(In reply to comment #8) > (From update of attachment 203910 [details]) > Thanks peavo for updating the patch. > r=me Thanks for the review :)
WebKit Commit Bot
Comment 10 2013-06-06 07:42:09 PDT
Comment on attachment 203910 [details] Patch Clearing flags on attachment: 203910 Committed r151271: <http://trac.webkit.org/changeset/151271>
WebKit Commit Bot
Comment 11 2013-06-06 07:42:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.