Bug 117255

Summary:

[WinCairo] Fix build-webkit to build WinCairo under VS2010.

Product:

WebKit

Reporter:

peavo

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, dbates

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description peavo 2013-06-05 07:42:39 PDT

The WinCairo build fails because the configuration names has changed in the VS2010 project,
and needs to be updated in the scripts.

Comment 1 peavo 2013-06-05 07:51:29 PDT

Created attachment 203851 [details]
Patch

Comment 2 Daniel Bates 2013-06-05 09:16:11 PDT

Comment on attachment 203851 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203851&action=review

This patch looks straightforward to me.

r=me

> Tools/ChangeLog:3
> +        [WinCairo] Build failure.

Do we know when the build began failing? From briefly looking through SVN history it looks like the WinCairo broken during the transition from VS2005 to VS2010. Maybe a more appropriate bug title would be "Fix build-webkit to build WinCairo under VS2010"?

Comment 3 Daniel Bates 2013-06-05 09:17:36 PDT

(In reply to comment #2)
> > Tools/ChangeLog:3
> > +        [WinCairo] Build failure.
> 
> Do we know when the build began failing? From briefly looking through SVN history it looks like the WinCairo broken during the transition from VS2005 to VS2010. Maybe a more appropriate bug title would be "Fix build-webkit to build WinCairo under VS2010"?

"WinCairo broken during" => "WinCairo build has been broken since"

Comment 4 peavo 2013-06-05 11:44:01 PDT

(In reply to comment #2)
> (From update of attachment 203851 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203851&action=review
> 
> This patch looks straightforward to me.
> 
> r=me
> 
> > Tools/ChangeLog:3
> > +        [WinCairo] Build failure.
> 
> Do we know when the build began failing? From briefly looking through SVN history it looks like the WinCairo broken during the transition from VS2005 to VS2010. Maybe a more appropriate bug title would be "Fix build-webkit to build WinCairo under VS2010"?

I'm not sure exactly when the WinCairo build started to fail.

Comment 5 Daniel Bates 2013-06-05 12:29:41 PDT

Comment on attachment 203851 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203851&action=review

>>> Tools/ChangeLog:3
>>> +        [WinCairo] Build failure.
>> 
>> Do we know when the build began failing? From briefly looking through SVN history it looks like the WinCairo broken during the transition from VS2005 to VS2010. Maybe a more appropriate bug title would be "Fix build-webkit to build WinCairo under VS2010"?
> 
> I'm not sure exactly when the WinCairo build started to fail.

OK. Please update the bug title in the ChangeLog entry before landing this patch.

Comment 6 peavo 2013-06-06 00:18:10 PDT

Created attachment 203910 [details]
Patch

Comment 7 peavo 2013-06-06 00:20:11 PDT

(In reply to comment #5)
> 
> OK. Please update the bug title in the ChangeLog entry before landing this patch.

Updated the title in the ChangeLog.

Comment 8 Daniel Bates 2013-06-06 07:20:20 PDT

Comment on attachment 203910 [details]
Patch

Thanks peavo for updating the patch.
r=me

Comment 9 peavo 2013-06-06 07:27:05 PDT

(In reply to comment #8)
> (From update of attachment 203910 [details])
> Thanks peavo for updating the patch.
> r=me

Thanks for the review :)

Comment 10 WebKit Commit Bot 2013-06-06 07:42:09 PDT

Comment on attachment 203910 [details]
Patch

Clearing flags on attachment: 203910

Committed r151271: <http://trac.webkit.org/changeset/151271>

Comment 11 WebKit Commit Bot 2013-06-06 07:42:12 PDT

All reviewed patches have been landed.  Closing bug.