Bug 117250 – [EFL] GraphicsSurface should flip content only if needed.

• Component: WebKit EFL
• Status: RESOLVED INVALID

[Kalyan]

GraphicsSurface has always been used with WebGL and it assumed the content needs to be flipped (texture coordinates are flipped. OpenGL has its origin at bottom-left.) As we plan to use GraphicsSurface for more use cases like accelerated video composition where we do software decoding and upload the contents to texture. Because of the above assumption we have to flip the contents before uploading it to texture which is than flipped again in GraphisSurface side. It would be nice if we flip the contents as needed.

[Kalyan]

Created attachment 203961 [details]
patch

[Kalyan]

Created attachment 204096 [details]
patchv2

[Noam Rosenthal]

Comment on attachment 204096 [details]
patchv2

View in context: https://bugs.webkit.org/attachment.cgi?id=204096&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayer.h:56
> +    virtual void setOptions(GraphicsSurface::Flags) { }

I can't review this part until I see how it's used...
Not sure why TextureMapper needs to know about any of this.

[Kalyan]

(In reply to comment #3)
> (From update of attachment 204096 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204096&action=review
> 
> > Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayer.h:56
> > +    virtual void setOptions(GraphicsSurface::Flags) { }
> 
> I can't review this part until I see how it's used...
> Not sure why TextureMapper needs to know about any of this.

This would give a possibility for the classes using GraphicsContext3D to set the needed flags for it's platform layer.

i.e in MediaStreamer code:

if (m_context3D->getInternalFramebufferSize() != size) {
    m_context3D->platformLayer()->setOptions(GraphicsSurface::SupportsTextureTarget | GraphicsSurface::SupportsSharing);
        m_context3D->reshape(size.width(), size.height());
    }

[Kalyan]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 204096 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=204096&action=review
> > 
> > > Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayer.h:56
> > > +    virtual void setOptions(GraphicsSurface::Flags) { }
> > 
> > I can't review this part until I see how it's used...
> > Not sure why TextureMapper needs to know about any of this.
> 
> This would give a possibility for the classes using GraphicsContext3D to set the needed flags for it's platform layer.
> 
> i.e in MediaStreamer code:
> 
> if (m_context3D->getInternalFramebufferSize() != size) {
>     m_context3D->platformLayer()->setOptions(GraphicsSurface::SupportsTextureTarget | GraphicsSurface::SupportsSharing);
>         m_context3D->reshape(size.width(), size.height());
>     }

Other option is to add "HasInvertedY" attribute to GraphicsContext3D(similar to alpha, stencil, shareResources etc). This would by default be true and than in cases like video we could set it to false. GraphicsContext3DPrivate would internally use it to determine appropriate flags for GraphicsSurface. We would not need any changes in TMPL.

[Kalyan]

Comment on attachment 204096 [details]
patchv2

Removing request for review. I will try GraphicsContext3D approach

[Kalyan]

Created attachment 204121 [details]
patchv3

[Kalyan]

Will be handled 117118