Summary: | [WK2][GTK] Let DrawingArea manage setAcceleratedCompositingWindowId | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gwang Yoon Hwang <yoon> | ||||||||||
Component: | WebKitGTK | Assignee: | Gwang Yoon Hwang <yoon> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | andersca, berto, cgarcia, commit-queue, gustavo, mrobinson | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 100341 | ||||||||||||
Attachments: |
|
Description
Gwang Yoon Hwang
2013-06-05 00:25:30 PDT
Created attachment 203997 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 203997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203997&action=review This change seems okay to me. I have suggestions for a few changes and after that it needs the approval of a WebKit owner. > Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:375 > +void DrawingAreaProxyImpl::setNativeCompositingSurfaceHandle(uint64_t handle) May I suggest a new name: setNativeSurfaceHandleForCompositing or setCompositingNativeSurfaceHandle. This eliminates any confusion between native "compositing surface handle" or a "surface handle" for native compositing. > Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h:99 > +#if USE(TEXTURE_MAPPER_GL) && PLATFORM(GTK) > + virtual void setNativeCompositingSurfaceHandle(uint64_t) { } > +#endif > + This is unused for this patch, so maybe it can be removed. Created attachment 205474 [details]
Patch
(In reply to comment #3) > (From update of attachment 203997 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203997&action=review > > This change seems okay to me. I have suggestions for a few changes and after that it needs the approval of a WebKit owner. > Sorry for late. :( > > Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:375 > > +void DrawingAreaProxyImpl::setNativeCompositingSurfaceHandle(uint64_t handle) > > May I suggest a new name: setNativeSurfaceHandleForCompositing or setCompositingNativeSurfaceHandle. This eliminates any confusion between native "compositing surface handle" or a "surface handle" for native compositing. > I prefer setNativeSurfaceHandleForCompositing. I've renamed with it. > > Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h:99 > > +#if USE(TEXTURE_MAPPER_GL) && PLATFORM(GTK) > > + virtual void setNativeCompositingSurfaceHandle(uint64_t) { } > > +#endif > > + > > This is unused for this patch, so maybe it can be removed. Yes, exactly. removed. Created attachment 206037 [details] Rebase after r152375 (In reply to comment #6) > Created an attachment (id=206037) [details] > Rebase after r152375 The previous patch looked good to me, so if this is just a rebase, you simply need an owner to approve it. Created attachment 242761 [details]
Patch
Comment on attachment 242761 [details] Patch Clearing flags on attachment: 242761 Committed r176954: <http://trac.webkit.org/changeset/176954> All reviewed patches have been landed. Closing bug. |