Bug 117224

Summary:

Cannot set a new timer inside of timer callback in RunLoopTimerGtk & RunLoopTimerEFL

Product:

WebKit

Reporter:

Gwang Yoon Hwang <yoon>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, gyuyoung.kim, jaepark, mrobinson, rakuco

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Gwang Yoon Hwang 2013-06-04 22:59:07 PDT

RunLoopTimer should clear its isActive flag before invoking timer
    callback.

Comment 1 Gwang Yoon Hwang 2013-06-06 03:43:37 PDT

Created attachment 203919 [details]
Patch

Comment 2 Martin Robinson 2013-06-06 03:49:36 PDT

Comment on attachment 203919 [details]
Patch

The GTK bits look good to me. Have you ensured all tests are passing as well?

Comment 3 Chris Dumez 2013-06-06 03:51:24 PDT

Comment on attachment 203919 [details]
Patch

Looks sane. r=me.

Comment 4 Chris Dumez 2013-06-06 03:52:40 PDT

Sorry, didn't see Martin's comment. Leaving cq? on.

Comment 5 Gwang Yoon Hwang 2013-06-06 06:27:51 PDT

(In reply to comment #2)
> (From update of attachment 203919 [details])
> The GTK bits look good to me. Have you ensured all tests are passing as well?

Yes, all tests passed.

Comment 6 Gwang Yoon Hwang 2013-06-06 06:29:40 PDT

(In reply to comment #4)
> Sorry, didn't see Martin's comment. Leaving cq? on.

Thanks for review. All tests are passed. Could you turn cq+?

Comment 7 WebKit Commit Bot 2013-06-06 06:52:47 PDT

Comment on attachment 203919 [details]
Patch

Clearing flags on attachment: 203919

Committed r151268: <http://trac.webkit.org/changeset/151268>

Comment 8 WebKit Commit Bot 2013-06-06 06:52:50 PDT

All reviewed patches have been landed.  Closing bug.