Bug 117204

Summary:

Remove [NoInterfaceObject] from XPathExpression and NodeIterator

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, arv, benjamin, commit-queue, esprehn+autocc, ggaren, gyuyoung.kim, haraken, rakuco

Priority:

Keywords:

WebExposed

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

115853

Attachments:

Description	Flags
Patch	ap: review+
Patch for landing	none

Description Chris Dumez 2013-06-04 10:12:37 PDT

XPathExpression and NodeIterator interfaces should not have [NoInterfaceObject] extended attribute according to their respective specifications:
http://www.w3.org/TR/DOM-Level-3-XPath/xpath.html#XPathExpression
http://www.w3.org/TR/DOM-Level-2-Traversal-Range/traversal.html#Traversal-NodeIterator

Comment 1 Chris Dumez 2013-06-04 10:30:55 PDT

Created attachment 203711 [details]
Patch

Comment 2 Alexey Proskuryakov 2013-06-04 10:38:57 PDT

Comment on attachment 203711 [details]
Patch

Looks like this matches Firefox at least...

Comment 3 Chris Dumez 2013-06-04 10:57:40 PDT

(In reply to comment #2)
> (From update of attachment 203711 [details])
> Looks like this matches Firefox at least...

Right. Sorry, I should have mentioned that.
I'm going to submit the same patch to Blink as well.

Comment 4 Chris Dumez 2013-06-04 11:55:59 PDT

Created attachment 203716 [details]
Patch for landing

Rebaseline fast/dom/dom-constructors.html as well.

Comment 5 WebKit Commit Bot 2013-06-04 13:27:29 PDT

Comment on attachment 203716 [details]
Patch for landing

Clearing flags on attachment: 203716

Committed r151182: <http://trac.webkit.org/changeset/151182>

Comment 6 WebKit Commit Bot 2013-06-04 13:27:33 PDT

All reviewed patches have been landed.  Closing bug.