Bug 117181

Summary: Refactor the code that decides whether to enable WebGL from settings to helper functions
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: New BugsAssignee: Noam Rosenthal <noam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Noam Rosenthal
Reported 2013-06-03 23:59:26 PDT
Refactor the code that decides whether to enable WebGL from settings to helper functions
Attachments
Patch (2.59 KB, patch)
2013-06-04 00:02 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch (2.61 KB, patch)
2013-06-04 06:51 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2013-06-04 00:02:41 PDT
Created attachment 203657 [details] Patch
Benjamin Poulain
Comment 2 2013-06-04 00:38:39 PDT
Comment on attachment 203657 [details] Patch I like the idea but the name webGLEnabled(Settings*) is confusing. What about canRunWebGL() or ableToRunWebGL()?
Noam Rosenthal
Comment 3 2013-06-04 01:10:56 PDT
(In reply to comment #2) > (From update of attachment 203657 [details]) > I like the idea but the name webGLEnabled(Settings*) is confusing. > > What about canRunWebGL() or ableToRunWebGL()? How about shouldEnableWebGL(Settings*) ?
Noam Rosenthal
Comment 4 2013-06-04 06:51:02 PDT
Created attachment 203690 [details] Patch
WebKit Commit Bot
Comment 5 2013-06-04 11:25:51 PDT
Comment on attachment 203690 [details] Patch Clearing flags on attachment: 203690 Committed r151176: <http://trac.webkit.org/changeset/151176>
WebKit Commit Bot
Comment 6 2013-06-04 11:25:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.