Summary: | [sh4] Add floating point absolute function support in baseline JIT | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Julien Brianceau <jbriance> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, fpizlo, ggaren, mark.lam, oliver | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Julien Brianceau
2013-06-03 07:21:24 PDT
Created attachment 203587 [details]
Add floating point absolute function support in sh4 baseline JIT
Attachment 203587 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/assembler/MacroAssemblerSH4.h', u'Source/JavaScriptCore/assembler/SH4Assembler.h']" exit_code: 1
Source/JavaScriptCore/assembler/SH4Assembler.h:181: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
I've tested this patch on r151092 and I didn't see regressions when running - Tools/Scripts/run-javascriptcore-tests - Tools/Scripts/run-fast-jsc - SunSpider 1.0 I used the following dumb test to measure the performance impact of this patch: var result = 1.123; for (var i = 0; i < 5000000; ++i) { result = result + Math.abs((i / -(i+1)) + (i * 1.1)); } Using r151092 jsc without patch, I get: real 0m 6.13s user 0m 6.00s sys 0m 0.10s Using r151092 jsc with patch, I get about 4.3% better: real 0m 5.57s user 0m 5.45s sys 0m 0.10s Comment on attachment 203587 [details]
Add floating point absolute function support in sh4 baseline JIT
r=me
Comment on attachment 203587 [details] Add floating point absolute function support in sh4 baseline JIT Clearing flags on attachment: 203587 Committed r151174: <http://trac.webkit.org/changeset/151174> All reviewed patches have been landed. Closing bug. |