Summary: | [wk2] WebProcess' page-in-window count can be wrong | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
Component: | WebKit2 | Assignee: | Tim Horton <thorton> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, simon.fraser, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tim Horton
2013-06-01 01:05:29 PDT
Created attachment 203483 [details]
patch
Comment on attachment 203483 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=203483&action=review > Source/WebKit2/ChangeLog:9 > + If we're using a single WebProcess and a window is closed, we were Maybe I should remove the bit about single WebProcess since there are cases where this can affect multiprocess too (if we're over the process cap or are using window.open or something). Comment on attachment 203483 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=203483&action=review > Source/WebKit2/WebProcess/WebProcess.h:316 > + HashSet<uint64_t> m_inWindowPageSet; inWindowPageSet sounds like something boolean. I guess this is "set of pages in any window"? (In reply to comment #4) > (From update of attachment 203483 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203483&action=review > > > Source/WebKit2/WebProcess/WebProcess.h:316 > > + HashSet<uint64_t> m_inWindowPageSet; > > inWindowPageSet sounds like something boolean. I guess this is "set of pages in any window"? It is "set of pages in this process that are parented in a window", yes. Comment on attachment 203483 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=203483&action=review >>> Source/WebKit2/WebProcess/WebProcess.h:316 >>> + HashSet<uint64_t> m_inWindowPageSet; >> >> inWindowPageSet sounds like something boolean. I guess this is "set of pages in any window"? > > It is "set of pages in this process that are parented in a window", yes. How about m_pagesInWindows or something similar. I don’t think you need to put the type in the variable name. |