Bug 116992

Summary:

[BlackBerry] Update Button UX

Product:

WebKit

Reporter:

Tiancheng Jiang <tijiang>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, glenn, macpherson, menard, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2	none
Patch	none

Tiancheng Jiang

Reported 2013-05-29 13:37:06 PDT

Update Button UX.

Attachments
Patch (1.73 KB, patch) 2013-05-29 14:16 PDT, Tiancheng Jiang	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (475.79 KB, application/zip) 2013-05-29 19:07 PDT, Build Bot	no flags	Details
Patch (1.48 KB, patch) 2013-05-31 13:02 PDT, Tiancheng Jiang	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tiancheng Jiang

Comment 1 2013-05-29 14:16:31 PDT

Created attachment 203275 [details] Patch

Build Bot

Comment 2 2013-05-29 19:07:55 PDT

Comment on attachment 203275 [details] Patch Attachment 203275 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/714258 New failing tests: fast/dom/location-new-window-no-crash.html

Build Bot

Comment 3 2013-05-29 19:07:57 PDT

Created attachment 203299 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3

Rob Buis

Comment 4 2013-05-31 11:47:27 PDT

Comment on attachment 203275 [details] Patch LGTM. The buildbot failure seems unrelated.

WebKit Commit Bot

Comment 5 2013-05-31 12:09:31 PDT

Comment on attachment 203275 [details] Patch Rejecting attachment 203275 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 203275, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /git.webkit.org/WebKit 7f2e314..9ecad5d master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 151033 = 7f2e31446f1e8b227d880e327ef1981ce2ea94e3 r151034 = 9ecad5d440f8b36890d591125421488f378366a6 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/742535

Tiancheng Jiang

Comment 6 2013-05-31 13:02:29 PDT

Created attachment 203464 [details] Patch

Rob Buis

Comment 7 2013-05-31 13:13:13 PDT

Comment on attachment 203464 [details] Patch Retry.

WebKit Commit Bot

Comment 8 2013-05-31 13:44:46 PDT

Comment on attachment 203464 [details] Patch Clearing flags on attachment: 203464 Committed r151037: <http://trac.webkit.org/changeset/151037>

WebKit Commit Bot

Comment 9 2013-05-31 13:44:49 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.