Bug 116929
| Summary: | Fix a crash when we try a focus navigation from a shadow host which is not keyboard navigatable, but focusable | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | kling, koivisto, llango.u-szeged |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/063e09f6f0b559cebdc8b972827e58f1f734336d
For example, suppose the following element:
<div id=host tabindex=-1></div>
host.webkitCreateShadowRoot()
This host element is focusable, but isn't keyboard navigatable.
We should relax the ASSERT condition so that this kind of element is okay as an old focused node.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
László Langó
The test does not crash. I think we don't need this.
Ryosuke Niwa
(In reply to comment #1)
> The test does not crash. I think we don't need this.
Did you test it on the port that enables shadow DOM?
László Langó
(In reply to comment #2)
> (In reply to comment #1)
> > The test does not crash. I think we don't need this.
>
> Did you test it on the port that enables shadow DOM?
I tried on Efl port with the --shadow-dom build option. Anyone tried this on other ports?
Ryosuke Niwa
Alright. We can file a new bug should this crash be real.