Bug 116918
| Summary: | SVGTests should lazyAttach | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, kling, koivisto, rbuis, sabouhallawa, thorton, zimmermann |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/1e2f01956de8cc2443040fb2670b7a21cd3f2f72
SVGTests::handleAttributeChange should use lazyAttach instead of calling
attach manually.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
This was reverted in https://chromium.googlesource.com/chromium/blink/+/22c6a843c811cb338f110ab92c793f1679c22719.
Ryosuke Niwa
(In reply to comment #1)
> This was reverted in https://chromium.googlesource.com/chromium/blink/+/22c6a843c811cb338f110ab92c793f1679c22719.
Subsequently re-landed in https://chromium.googlesource.com/chromium/blink/+/36f31931bd9e6873a994fe3d16197fa2a6b37d6e.
Rob Buis
I think this can be closed since since r160908 the render tree is created lazily.
Ahmad Saleem
Can this be closed as "RESOLVED CONFIGURATION CHANGED" as per response in Comment 3. Thanks!