Bug 116912
| Summary: | ShadowRoot should not call recalcStyle outside document level recalcStyle | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, kling, koivisto |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/5dd4e2573b952c7f1cc91509f92a1079ed4b037b
Document::recalcStyle does lots of setup for painting, event scheduling and also sets
the inStyleRecalc flag so code knows we're in the middle of a style recalc.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Also https://chromium.googlesource.com/chromium/blink/+/3ced7695724187888264ce531eb627959e5f9087, which adds an assertion for this.
Ahmad Saleem
rniwa@webkit.org - You are working on Shadow DOM or bit around those, is this needed anymore? Thanks!
Ryosuke Niwa
This code has been quite a bit rewritten in WebKit since then.