Bug 116909 – User is not removed by setUser() in KURL

• Component: Platform
• Status: RESOLVED INVALID

[Meeyoung Kim]

"Committed r114843" has a bug when it is called from strippedForUseAsReferrer() and removeCredentials().

In these case, the aim of setUser() and setPass() is that removing the user and passward from m_string.

But the user is not removed from m_string. Because user is empty.

[Meeyoung Kim]

Created attachment 203123 [details]
Improve performance of removing user and password from URLs By making the new remove function.

To improve performance of removing user and password from URLs, the new function is used in strippedForUseAsReferrer() and removeCredentials(), instead of setUser() and setPass().

[WebKit Commit Bot]

Comment on attachment 203123 [details]
Improve performance of removing user and password from URLs By making the new remove function.

Rejecting attachment 203123 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[Darin Adler]

Comment on attachment 203123 [details]
Improve performance of removing user and password from URLs By making the new remove function.

Patches need to include change log. Patches that are supposed to be performance optimizations need to have performance data. Patches that are supposed to fix bugs need to come with regression tests showing the bug is fixed.

[Meeyoung Kim]

I will check it, again. Thank you.

[Meeyoung Kim]

Invalid description(not a bug). I change the status of this bug.