Bug 116906

Summary: REGRESSION (r150169): Images from file: URLs display after a delay even though they were preloaded by JavaScript
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 113626    
Bug Blocks: 117007    
Attachments:
Description Flags
Patch kling: review+

Description Andy Estes 2013-05-28 21:16:27 PDT
REGRESSION (r150169): Images from file: URLs display after a delay even though they were preloaded by JavaScript
Comment 1 Andy Estes 2013-05-28 21:18:17 PDT
<rdar://problem/13991927>
Comment 2 Andy Estes 2013-05-28 21:27:12 PDT
Created attachment 203118 [details]
Patch
Comment 3 Andreas Kling 2013-05-28 21:51:29 PDT
Comment on attachment 203118 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203118&action=review

r=me.

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=116906

It's nice to have the rdar:// link here too. Your future bisecting self will thank you. :)
Comment 4 Andy Estes 2013-05-28 21:55:58 PDT
Committed r150863: <http://trac.webkit.org/changeset/150863>
Comment 5 Darin Adler 2013-05-29 12:18:23 PDT
Comment on attachment 203118 [details]
Patch

I’m not sure this can be the last word on the subject. Caching local files indefinitely even after the files change on disk does not seem like good behavior for us to keep forever. And for unknown custom schemes it could also be unacceptable. Seems like we need to rethink this to get it right long term.
Comment 6 Andy Estes 2013-05-29 16:07:30 PDT
(In reply to comment #5)
> (From update of attachment 203118 [details])
> I’m not sure this can be the last word on the subject. Caching local files indefinitely even after the files change on disk does not seem like good behavior for us to keep forever. And for unknown custom schemes it could also be unacceptable. Seems like we need to rethink this to get it right long term.

I agree with you. I wrote up my thoughts on how to improve this situation here:

https://bugs.webkit.org/show_bug.cgi?id=117007