Bug 11681 – REGRESSION: Resetting a multiple-select control selects first item rather than none

• Component: Forms
• Status: RESOLVED FIXED

[Kirby White]

Multiple-select form controls default to having nothing selected when the page is loaded, but when the form is reset with an <input type="reset"> or <button type="reset"> control they have the first item selected instead.

[Kirby White]

Created attachment 11616 [details]
Checks for multiple-select before setting option on reset

Comment on attachment 11616 [details]
Checks for multiple-select before setting option on reset

The code change looks good, but shouldn't the same logic apply also to single-choice listboxes (e.g. <select size="5">)? It would be nice to fix this case as well.

+        WARNING: NO TEST CASES ADDED OR CHANGED

You should indeed add a layout test.

r- due to the missing test.

[Kirby White]

Created attachment 11647 [details]
Adding testcase

As I understand the spec, single-choice <select> controls with no "selected" option properly default to the first option when reset, whereas multiple-choice ones reset to empty.  That makes sense, at least to me, since otherwise the single-select's drop-down wouldn't have anything to show.

(In reply to comment #3)
> Created an attachment (id=11647) [edit]
> Adding testcase
> 
> As I understand the spec, single-choice <select> controls with no "selected"
> option properly default to the first option when reset, whereas multiple-choice
> ones reset to empty.  That makes sense, at least to me, since otherwise the
> single-select's drop-down wouldn't have anything to show.
> 

My comment was referring to single-select list boxes, not drop-downs. The behavior of the former in WebKit and Firefox is that initially they have no option selected. Furthermore, in Firefox, resetting the form deselects all options. So I was suggesting that WebKit do the same to be consistent both with itself and with Firefox.

[Adele Peterson]

Comment on attachment 11647 [details]
Adding testcase

I agree with Mitz's comments.  You can use usesMenuList(), and only set the selection if that is true, instead of just checking m_multiple.

[Kirby White]

Created attachment 11653 [details]
Apply change to all listbox <select> controls

(In reply to comment #4)
> My comment was referring to single-select list boxes, not drop-downs.

Oh, of course.  Sorry, I misunderstood.  Here's the fix.

[Alexey Proskuryakov]

Comment on attachment 11653 [details]
Apply change to all listbox <select> controls

r=me

[Alexey Proskuryakov]

Committed revision 18019. I corrected formatting of the test, as it used tabs.

This was a regression, marking as such.