Bug 116803

Summary:

Encapsulate FontGlyphs

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Text

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, d-r, esprehn+autocc, fmalita, glenn, kling, pdr, schenney

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	kling: review+

Description Antti Koivisto 2013-05-26 18:09:55 PDT

Defriend Font.

Comment 1 Antti Koivisto 2013-05-26 18:24:36 PDT

Created attachment 202942 [details]
patch

Comment 2 Andreas Kling 2013-05-26 18:36:43 PDT

Comment on attachment 202942 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202942&action=review

r=me

> Source/WebCore/ChangeLog:21
> +            Helpers form FontFastPath.cpp.

Typo, from.

> Source/WebCore/platform/graphics/FontFallbackList.cpp:62
> +    m_realizedFontData.append(fontData);

You should .release() the RefPtr here. Or make it a one-liner.

Comment 3 Antti Koivisto 2013-05-26 18:41:22 PDT

http://trac.webkit.org/changeset/150730