Bug 116793

Summary: fourthTier: clean up ArithDiv/ArithMod in the DFG
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 116792    
Attachments:
Description Flags
work in progress
none
the patch mhahnenberg: review+

Filip Pizlo
Reported 2013-05-26 11:18:52 PDT
We need to do this. I can no longer reason about this code because it's so bad.
Attachments
work in progress (33.49 KB, patch)
2013-05-26 11:20 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (115.54 KB, patch)
2013-05-26 19:19 PDT, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-05-26 11:20:34 PDT
Created attachment 202927 [details] work in progress
Filip Pizlo
Comment 2 2013-05-26 19:19:29 PDT
Created attachment 202945 [details] the patch
Mark Hahnenberg
Comment 3 2013-05-27 10:20:02 PDT
Comment on attachment 202945 [details] the patch r=me
Filip Pizlo
Comment 4 2013-05-27 10:39:50 PDT
Landed in http://trac.webkit.org/changeset/150765
Note You need to log in before you can comment on or make changes to this bug.