| Summary: | Move "active" state logic from Node to Element. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
| Component: | DOM | Assignee: | Andreas Kling <kling> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, kling, webkit-ews | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Andreas Kling
2013-05-26 07:03:42 PDT
Created attachment 202919 [details]
Patch
Attachment 202919 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AccessibilityNodeObject.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/ContainerNode.h', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Node.h', u'Source/WebCore/dom/UserActionElementSet.h', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLAnchorElement.h', u'Source/WebCore/html/HTMLLabelElement.h', u'Source/WebCore/html/shadow/MediaControlElementTypes.h', u'Source/WebCore/rendering/RenderTheme.cpp', u'Source/WebCore/rendering/RenderThemeMac.mm']" exit_code: 1
Source/WebCore/dom/Element.cpp:503: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/dom/Element.cpp:505: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Total errors found: 2 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 202919 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202919&action=review > Source/WebCore/dom/Element.cpp:517 > + // FIXME: Find a substitute for usleep for Win32. You should remove this. > Source/WebCore/dom/Element.cpp:518 > + // Better yet, come up with a way of doing this that doesn't use this sort of thing at all. And make this the FIXME. Comment on attachment 202919 [details] Patch Attachment 202919 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/744181 Comment on attachment 202919 [details] Patch Attachment 202919 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/730166 Committed r150715: <http://trac.webkit.org/changeset/150715> |