Bug 116780

Summary: FocusController::setFocusedNode() should be setFocusedElement().
Product: WebKit Reporter: Andreas Kling <kling>
Component: DOMAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
A patch?
webkit-ews: commit-queue-
Please? koivisto: review+

Description Andreas Kling 2013-05-26 03:50:28 PDT
FocusController::setFocusedNode() should be setFocusedElement().
Comment 1 Andreas Kling 2013-05-26 04:00:44 PDT
Created attachment 202911 [details]
A patch?
Comment 2 WebKit Commit Bot 2013-05-26 04:03:10 PDT
Attachment 202911 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/editing/htmlediting.h', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/FocusController.cpp', u'Source/WebCore/page/FocusController.h', u'Source/WebKit/blackberry/Api/WebPage.cpp', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp']" exit_code: 1
Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1035:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2013-05-26 04:08:30 PDT
Comment on attachment 202911 [details]
A patch?

Attachment 202911 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/652326
Comment 4 Early Warning System Bot 2013-05-26 04:09:32 PDT
Comment on attachment 202911 [details]
A patch?

Attachment 202911 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/686453
Comment 5 Andreas Kling 2013-05-26 04:10:53 PDT
Created attachment 202912 [details]
Please?
Comment 6 Antti Koivisto 2013-05-26 04:12:48 PDT
Comment on attachment 202912 [details]
Please?

nice
Comment 7 Andreas Kling 2013-05-26 04:38:59 PDT
Committed r150712: <http://trac.webkit.org/changeset/150712>