[S60] tabbing navigation skips over text content

• Component: Layout and Rendering
• Status: CLOSED FIXED

[Shaun Keller]

TSW# TMCN-6TLQ58

[Shaun Keller]

Created attachment 11608 [details]
tabbing navigation fix

[zalan]

Comment on attachment 11608 [details]
tabbing navigation fix

in getNewTabbedCursorPosition, you use the same variable name (as the parameter of this function) to call the subframe's getNewTabbedCursorPosition. is it intentional? as with this setup your nodeIndex remains -1 even if it is set to something else in the subframe call. 

int nodeIndex = -1;
bool foundInFrame = foundFrame->getNewTabbedCursorPosition(lr,tb,nodeIndex);


in tabbedNavigation, it looks to me that nodeIndex can be easily -1 and that crashes on the following line
QRect foundRect = (*_focusableNodeList)[nodeIndex];

and please remove the FIXME comment

[Shaun Keller]

Created attachment 11642 [details]
apply corrections based on Zalan's comments

Thanks for catching the nodeIndex errors.  The delta is: removed the creation of shadowing variables; added a test for return nodeIndex value of -1 which now skips over changing the cursor position based on a found node; corrected comments and indenting.  I rebuilt, tested and reviewed the changes with Sriram.

[Shaun Keller]

Created attachment 11643 [details]
retry at usable diff/patch

[zalan]

Comment on attachment 11642 [details]
apply corrections based on Zalan's comments

r=me

[zalan]

Comment on attachment 11643 [details]
retry at usable diff/patch

r=me

[zalan]

3.2 17914
3.1m 17915

[Krishna]

Verified and Closed.