| Summary: | We broke (-2^31/-1)|0 in the DFG | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Filip Pizlo
2013-05-25 14:31:04 PDT
Created attachment 202894 [details]
the patch
Comment on attachment 202894 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=202894&action=review r=me > Source/JavaScriptCore/ChangeLog:9 > + The bug is that we were assuming that inthe -2^31 case, we already had -2^31 > + in the result register. This was a wrong assumption. Fatfinger, in the. (In reply to comment #2) > (From update of attachment 202894 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=202894&action=review > > r=me > > > Source/JavaScriptCore/ChangeLog:9 > > + The bug is that we were assuming that inthe -2^31 case, we already had -2^31 > > + in the result register. This was a wrong assumption. > > Fatfinger, in the. Thanks, fixed! Landed in http://trac.webkit.org/changeset/150694 |