Bug 116765

Summary:

Path: clean up addPathForRoundedRect()

Product:

WebKit

Reporter:

Alberto Garcia <berto>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Alberto Garcia

Reported 2013-05-25 12:29:42 PDT

The current implementation of Path::addPathForRoundedRect() is a bit confusing and redundant if (preferBezier) { bezier(); return; } #if CG || BLACKBERRY native(); #else bezier(); #fi I would suggest something like #if CG || BLACKBERRY if (preferNative) { native(); return; } #endif bezier();

Attachments
Patch (1.92 KB, patch) 2013-05-25 12:35 PDT, Alberto Garcia	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alberto Garcia

Comment 1 2013-05-25 12:35:17 PDT

Created attachment 202891 [details] Patch Here's the patch. The only reason why I put the #ifdef inside the if() block is to avoid a "unused parameter: strategy" warning.

WebKit Commit Bot

Comment 2 2013-05-25 17:50:44 PDT

Comment on attachment 202891 [details] Patch Clearing flags on attachment: 202891 Committed r150696: <http://trac.webkit.org/changeset/150696>

WebKit Commit Bot

Comment 3 2013-05-25 17:50:46 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.