Bug 116759 – Page::focusController() should return a reference.

• Component: DOM
• Status: RESOLVED FIXED

[Andreas Kling]

Page::focusController() should return a reference.

[Andreas Kling]

Created attachment 202880 [details]
Patch

[WebKit Commit Bot]

Attachment 202880 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AXObjectCache.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/css/SelectorChecker.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/TreeScope.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/history/CachedPage.cpp', u'Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp', u'Source/WebCore/html/HTMLDocument.cpp', u'Source/WebCore/html/HTMLFrameElementBase.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/mac/EventHandlerMac.mm', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderListBox.cpp', u'Source/WebCore/rendering/RenderTheme.cpp', u'Source/WebKit/blackberry/Api/WebPage.cpp', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebKitSupport/BackingStoreClient.cpp', u'Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp', u'Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp', u'Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/efl/ewk/ewk_view.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/WebViewInputMethodFilter.cpp', u'Source/WebKit/gtk/webkit/webkitwebinspector.cpp', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp', u'Source/WebKit/qt/WebCoreSupport/EditorClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit/wince/ChangeLog', u'Source/WebKit/wince/WebView.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm', u'Source/WebKit2/WebProcess/Plugins/PDF/SimplePDFPlugin.mm', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm', u'Source/WebKit2/WebProcess/WebPage/FindController.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/efl/WebPageEfl.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp']" exit_code: 1
Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1035:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 63 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 202880 [details]
Patch

Attachment 202880 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/737054

[Early Warning System Bot]

Comment on attachment 202880 [details]
Patch

Attachment 202880 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/704166

[EFL EWS Bot]

Comment on attachment 202880 [details]
Patch

Attachment 202880 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/723086

[Andreas Kling]

Created attachment 202881 [details]
Patch

[Early Warning System Bot]

Comment on attachment 202881 [details]
Patch

Attachment 202881 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/683146

[Early Warning System Bot]

Comment on attachment 202881 [details]
Patch

Attachment 202881 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/689088

[EFL EWS Bot]

Comment on attachment 202881 [details]
Patch

Attachment 202881 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/704173

[Build Bot]

Comment on attachment 202881 [details]
Patch

Attachment 202881 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/683150