Bug 116743

Summary:

MessageSender shouldn't be a class template

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, eflews.bot, gyuyoung.kim, webkit-ews

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+, eflews.bot: commit-queue-

Description Anders Carlsson 2013-05-24 15:43:08 PDT

MessageSender shouldn't be a class template

Comment 1 Anders Carlsson 2013-05-24 15:47:35 PDT

Created attachment 202857 [details]
Patch

Comment 2 EFL EWS Bot 2013-05-24 15:55:20 PDT

Comment on attachment 202857 [details]
Patch

Attachment 202857 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/671095

Comment 3 Early Warning System Bot 2013-05-24 15:56:44 PDT

Comment on attachment 202857 [details]
Patch

Attachment 202857 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/669069

Comment 4 Andreas Kling 2013-05-24 17:12:40 PDT

Comment on attachment 202857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202857&action=review

> Source/WebKit2/Platform/CoreIPC/MessageSender.h:69
> +    virtual Connection* messageSenderConnection() = 0;
> +    virtual uint64_t messageSenderDestinationID() = 0;

r=me if you mark all overrides as both "virtual" and "OVERRIDE"

Comment 5 Anders Carlsson 2013-05-24 17:16:58 PDT

Committed r150669: <http://trac.webkit.org/changeset/150669>