Bug 116743

Summary: MessageSender shouldn't be a class template
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, eflews.bot, gyuyoung.kim, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+, eflews.bot: commit-queue-

Anders Carlsson
Reported 2013-05-24 15:43:08 PDT
MessageSender shouldn't be a class template
Attachments
Patch (91.00 KB, patch)
2013-05-24 15:47 PDT, Anders Carlsson 		kling: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-05-24 15:47:35 PDT
Created attachment 202857 [details] Patch
EFL EWS Bot
Comment 2 2013-05-24 15:55:20 PDT
Comment on attachment 202857 [details] Patch Attachment 202857 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/671095
Early Warning System Bot
Comment 3 2013-05-24 15:56:44 PDT
Comment on attachment 202857 [details] Patch Attachment 202857 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/669069
Andreas Kling
Comment 4 2013-05-24 17:12:40 PDT
Comment on attachment 202857 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202857&action=review > Source/WebKit2/Platform/CoreIPC/MessageSender.h:69 > + virtual Connection* messageSenderConnection() = 0; > + virtual uint64_t messageSenderDestinationID() = 0; r=me if you mark all overrides as both "virtual" and "OVERRIDE"
Anders Carlsson
Comment 5 2013-05-24 17:16:58 PDT
Committed r150669: <http://trac.webkit.org/changeset/150669>
Note You need to log in before you can comment on or make changes to this bug.